PR #124

Hmm, no ranks after expanding, or in the trending section.

Since the last redesign this pr became a bit pointless but I guess that's all the more reason to not close it.

That looks nice. I was just looking for a low-lift solution, and those PRs already had a rank of zero in your code. I prefer your new approach, however.

Absolute rank is now stored in PullRequest itself and non-qualifying prs say N/A.

Was the only reason for zeroing the rank to not distinguish number 1?

One thing to flag: after merging into main, the "Trending This Week" section (added in #69) shows "0" for each PR because it passes rank=0.

A quick fix would be to fall back to the PR number when there's no rank:

<b>{rank > 0 ? rank : `#${pr.number}`}</b>

That way, ranked sections show the position and unranked sections show the PR number like before.

I like the way you've handled it, numbering them as they're sorted on the page.

Now that failing pull requests are at the bottom, how should the rank number behave? Include failing? Not? Show both?

This is a big improvement!

🤖 OpenChaos Bot

Summary: This PR modifies the PRCard component to display the rank instead of the PR number in the leading rank cell, and displays the PR number along with the title.

Files changed: 1 (src/components/PRCard.tsx)

Impact: Low - Only affects the display of PR information in the PRCard component.

openchaos-bot