PR #106

9 votes · 7 up · 2 down

View on GitHub
9
Total Votes
+7
Upvotes
-2
Downvotes
+7-2

Comments(12)

github-actions[bot]Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

SUCCUMBED TO OLD AGE

This PR has died from natural causes after 31 days.

Mortality Report:

  • Age: 31 days
  • Fitness (interactions): 20
  • Death probability: 6.99%
  • Fatal roll: 4.44

In the chaos world, PRs must move fast or perish. Only sustained engagement and timely merges can fight the effects of aging.

Senectus ipsa est morbus. (Old age itself is a disease.)

🔒 This PR has been locked. No resurrection is possible.


🕊️ May this PR rest in the git log.

DavieyComment#106ci: Replace eslint with Biome.js and introduce Lefthook

👎 Eslint replacement, boring tooling

ro0NLComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Less changes. I upvote.

pbabbicolaComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Okay I've set the indentStyle to two spaces and quoteStyle to single

omg that took down like half of the adds. Were the single quotes more frequent?

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

Okay I've set the indentStyle to two spaces and quoteStyle to single

pbabbicolaComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Many changes. I downvote.

To be fair 99% are changing the tab space.

ro0NLComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Many changes. I downvote.

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

I mean you only have to check the commit I mentioned contains only the results of npm run format -- --fix. Maybe it can be done

gh pr checkout 106
git reset --hard @^
npm i
npm run -- --format
git diff 6e3d782 @      # I am not sure

It was my fault in English.

matthewmayerComment#106ci: Replace eslint with Biome.js and introduce Lefthook

so you only have to verify whether I lie or not.

Do you lie or not?

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

Oh, you accidentally clicked downvoted. But it is okay because the huge changes only done in 6e3d782 and it is auto-generated by npm run format -- --fix so you only have to verify whether I lie or not.

matthewmayerComment#106ci: Replace eslint with Biome.js and introduce Lefthook

I have carefully reviewed all 3617 additions and 7603 deletions by hand.

LGTM

image

openchaos-bot[bot]Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

🤖 OpenChaos Bot

Summary: This PR migrates the project from ESLint to Biome for linting and formatting and adds a Lefthook configuration for pre-push formatting.

Files changed: 5 (biome.json, lefthook.yml, package-lock.json, package.json, eslint.config.mjs)

Impact: High - This changes the core linting and formatting tooling of the project, potentially affecting code style and quality enforcement.

⚠️ Large PR - partial review

openchaos-bot

All Activity(22)

github-actions[bot]Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

SUCCUMBED TO OLD AGE

This PR has died from natural causes after 31 days.

Mortality Report:

  • Age: 31 days
  • Fitness (interactions): 20
  • Death probability: 6.99%
  • Fatal roll: 4.44

In the chaos world, PRs must move fast or perish. Only sustained engagement and timely merges can fight the effects of aging.

Senectus ipsa est morbus. (Old age itself is a disease.)

🔒 This PR has been locked. No resurrection is possible.


🕊️ May this PR rest in the git log.

DavieyComment#106ci: Replace eslint with Biome.js and introduce Lefthook

👎 Eslint replacement, boring tooling

ro0NLComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Less changes. I upvote.

pbabbicolaComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Okay I've set the indentStyle to two spaces and quoteStyle to single

omg that took down like half of the adds. Were the single quotes more frequent?

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

Okay I've set the indentStyle to two spaces and quoteStyle to single

pbabbicolaComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Many changes. I downvote.

To be fair 99% are changing the tab space.

ro0NLComment#106ci: Replace eslint with Biome.js and introduce Lefthook

Many changes. I downvote.

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

I mean you only have to check the commit I mentioned contains only the results of npm run format -- --fix. Maybe it can be done

gh pr checkout 106
git reset --hard @^
npm i
npm run -- --format
git diff 6e3d782 @      # I am not sure

It was my fault in English.

matthewmayerComment#106ci: Replace eslint with Biome.js and introduce Lefthook

so you only have to verify whether I lie or not.

Do you lie or not?

lens0021Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

Oh, you accidentally clicked downvoted. But it is okay because the huge changes only done in 6e3d782 and it is auto-generated by npm run format -- --fix so you only have to verify whether I lie or not.

matthewmayerComment#106ci: Replace eslint with Biome.js and introduce Lefthook

I have carefully reviewed all 3617 additions and 7603 deletions by hand.

LGTM

image

openchaos-bot[bot]Comment#106ci: Replace eslint with Biome.js and introduce Lefthook

🤖 OpenChaos Bot

Summary: This PR migrates the project from ESLint to Biome for linting and formatting and adds a Lefthook configuration for pre-push formatting.

Files changed: 5 (biome.json, lefthook.yml, package-lock.json, package.json, eslint.config.mjs)

Impact: High - This changes the core linting and formatting tooling of the project, potentially affecting code style and quality enforcement.

⚠️ Large PR - partial review

openchaos-bot