PR #194

13 votes · 12 up · 1 down

View on GitHub
13
Total Votes
+12
Upvotes
-1
Downvotes
+12-1

Comments(8)

SaturateComment#194Post a pic or your PR won't stick

Should also do the check in the automated daily merge action.

Good point, thanks.

matthewmayerComment#194Post a pic or your PR won't stick

Should also do the check in the automated daily merge action.

SaturateComment#194Post a pic or your PR won't stick

A video's fine, it's pictures in a line. Upload away, your PR will stay.

SaturateComment#194Post a pic or your PR won't stick

The picture rule is merged and clean, the simplest check you've ever seen. No pic? No merge. That's internet law — enforced at last, without a flaw.

The stray files purged, the logic tight, @matthewmayer set us right. Now every PR, big or small, must drag and drop or face the wall.

fin.

💬
matthewmayerReview comment#194

this and a few other files were likely added by mistake in this PR

💬
matthewmayerReview comment#194

this can be refactored to make it more DRY and avoid a combinatorial explosion i.e.

const issues = [];

if (!pr.isMergeable) issues.push("Merge conflicts");
if (!containsRhymes) issues.push("No rhyme");
if (!pr.hasPicture) issues.push("No pic");
if (!pr.checksPassed) issues.push("Checks failed");
openchaos-bot[bot]Comment#194Post a pic or your PR won't stick

🤖 OpenChaos Bot

Summary: This PR adds a new rule to OpenChaos requiring PRs to include a picture uploaded directly to GitHub in order to be eligible for merging. It also updates the UI to reflect this new rule.

Files changed: 4 (README.md, src/components/PRCard.tsx, src/lib/github.ts, src/lib/pictures.ts)

Vibe: This PR is adding fuel to the fire of chaos, as if internet democracy needed more arbitrary rules.


openchaos-bot

All Activity(22)

SaturateComment#194Post a pic or your PR won't stick

Should also do the check in the automated daily merge action.

Good point, thanks.

matthewmayerComment#194Post a pic or your PR won't stick

Should also do the check in the automated daily merge action.

SaturateComment#194Post a pic or your PR won't stick

A video's fine, it's pictures in a line. Upload away, your PR will stay.

SaturateComment#194Post a pic or your PR won't stick

The picture rule is merged and clean, the simplest check you've ever seen. No pic? No merge. That's internet law — enforced at last, without a flaw.

The stray files purged, the logic tight, @matthewmayer set us right. Now every PR, big or small, must drag and drop or face the wall.

fin.

💬
matthewmayerReview comment#194

this and a few other files were likely added by mistake in this PR

💬
matthewmayerReview comment#194

this can be refactored to make it more DRY and avoid a combinatorial explosion i.e.

const issues = [];

if (!pr.isMergeable) issues.push("Merge conflicts");
if (!containsRhymes) issues.push("No rhyme");
if (!pr.hasPicture) issues.push("No pic");
if (!pr.checksPassed) issues.push("Checks failed");
openchaos-bot[bot]Comment#194Post a pic or your PR won't stick

🤖 OpenChaos Bot

Summary: This PR adds a new rule to OpenChaos requiring PRs to include a picture uploaded directly to GitHub in order to be eligible for merging. It also updates the UI to reflect this new rule.

Files changed: 4 (README.md, src/components/PRCard.tsx, src/lib/github.ts, src/lib/pictures.ts)

Vibe: This PR is adding fuel to the fire of chaos, as if internet democracy needed more arbitrary rules.


openchaos-bot