PR #199

11 votes · 9 up · 2 down

View on GitHub
11
Total Votes
+9
Upvotes
-2
Downvotes
+9-2

Comments(6)

▸
matthewmayerComment#199Add author quote to earn your vote

Suggest also adding an explanation of how to add a pitch to README .

▸
matthewmayerComment#199Add author quote to earn your vote

Doesn't look like there's any risk of injection here

Famous last words

▸
bpottleComment#199Add author quote to earn your vote

Yeah I'm somehow just realizing now that you're gonna break the shit outta this element with unsanitized input, lemme get after that.

▸
matthewmayerComment#199Add author quote to earn your vote

Should truncate to a length limit, to avoid paragraph-long or site-breaking pitches? Eg PR titles are generally max 70 chars and GitHub has a hard limit of 256.

▸
bigintersmindComment#199Add author quote to earn your vote

This is a super cool idea

▸
openchaos-bot[bot]Comment#199Add author quote to earn your vote

🤖 OpenChaos Bot

Summary: This PR adds support for authors to include a short "pitch" in their PRs, which is then displayed on the PR card on the site. The pitch is parsed from an HTML comment in the PR body.

Files changed: 4 (src/app/web2/web2.css, src/components/PRCard.tsx, src/components/ascii/PRCard.tsx, src/lib/github.ts)

Vibe: A calculated move to inject a sliver of sanity into the glorious bedlam.

openchaos-bot

All Activity(20)

▸
matthewmayerComment#199Add author quote to earn your vote

Suggest also adding an explanation of how to add a pitch to README .

▸
matthewmayerComment#199Add author quote to earn your vote

Doesn't look like there's any risk of injection here

Famous last words

▸
bpottleComment#199Add author quote to earn your vote

Yeah I'm somehow just realizing now that you're gonna break the shit outta this element with unsanitized input, lemme get after that.

▸
matthewmayerComment#199Add author quote to earn your vote

Should truncate to a length limit, to avoid paragraph-long or site-breaking pitches? Eg PR titles are generally max 70 chars and GitHub has a hard limit of 256.

▸
bigintersmindComment#199Add author quote to earn your vote

This is a super cool idea

▸
openchaos-bot[bot]Comment#199Add author quote to earn your vote

🤖 OpenChaos Bot

Summary: This PR adds support for authors to include a short "pitch" in their PRs, which is then displayed on the PR card on the site. The pitch is parsed from an HTML comment in the PR body.

Files changed: 4 (src/app/web2/web2.css, src/components/PRCard.tsx, src/components/ascii/PRCard.tsx, src/lib/github.ts)

Vibe: A calculated move to inject a sliver of sanity into the glorious bedlam.

openchaos-bot