PR #6

929 votes · 900 up · 29 down

View on GitHub
929
Total Votes
+900
Upvotes
-29
Downvotes
+900-29

Comments(12)

skridlevskyComment#6Calculate `+1` and `-1` reaction

🎉 First community merge. Congrats @yokeTH!

Victor4XComment#6Calculate `+1` and `-1` reaction

How about a "Recently Edited" badge for PR's edited within the last 24 hours, and then having those same PR's be ineligible for merging in that period?

jason-curtisComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

    This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

2 part proposal:

  1. Add a GitHub Actions check that ensures that the code changes in the PR are limited to what is described in the PR description. Use an LLM for this. If there are extra changes, fail the check and disqualify the PR from merging.
  2. Disallow PR editing: if a PR description is edited, the PR is auto-rejected and the author needs to create a new one.
bigintersmindComment#6Calculate `+1` and `-1` reaction

Also, with every revision, does everyone who reacted need to react again with every change?

Perhaps we should use a database and implement voting via the frontend, rather than GitHub reactions.

Then we could tie votes to the commit SHA and other methods.

yokeTHComment#6Calculate `+1` and `-1` reaction

Can you please also sneak in the changes from #51 into this PR?

LOL, I’m really sorry, but I can’t do that.

The true reason is the same as why Bitcoin takes 10 minutes to close a block and takes the 2016 block to calculate its difficulty. 🫣

vytskaltComment#6Calculate `+1` and `-1` reaction

Can you please also sneak in the changes from #51 into this PR?

yokeTHComment#6Calculate `+1` and `-1` reaction

Hey there!

Just wondering, how does SHA-based hashing work for conflict resolution?

Also, with every revision, does everyone who reacted need to react again with every change?

P.S. This is a PR with a +1 -1 calculation. Maybe you should open a new PR/issue to chat about it?

P.S. 2 I’m on the same page as you. The owner of the top PR might sneak in some malicious code at the last minute.

HeadlineComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

Or every revision resets votes? Sane authors will draft PRs?

haampieComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

yokeTHComment#6Calculate `+1` and `-1` reaction

I updated the README. I think that the ‘Newest Wins' rule is important, if a PR gets the same number of votes in less time it proves that it is more viral and is trending faster.

WeetileComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

All Activity(500)

skridlevskyComment#6Calculate `+1` and `-1` reaction

🎉 First community merge. Congrats @yokeTH!

Victor4XComment#6Calculate `+1` and `-1` reaction

How about a "Recently Edited" badge for PR's edited within the last 24 hours, and then having those same PR's be ineligible for merging in that period?

jason-curtisComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

    This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

2 part proposal:

  1. Add a GitHub Actions check that ensures that the code changes in the PR are limited to what is described in the PR description. Use an LLM for this. If there are extra changes, fail the check and disqualify the PR from merging.
  2. Disallow PR editing: if a PR description is edited, the PR is auto-rejected and the author needs to create a new one.
brwReaction#6👍
bigintersmindComment#6Calculate `+1` and `-1` reaction

Also, with every revision, does everyone who reacted need to react again with every change?

Perhaps we should use a database and implement voting via the frontend, rather than GitHub reactions.

Then we could tie votes to the commit SHA and other methods.

nhhReaction#6👍
yokeTHComment#6Calculate `+1` and `-1` reaction

Can you please also sneak in the changes from #51 into this PR?

LOL, I’m really sorry, but I can’t do that.

The true reason is the same as why Bitcoin takes 10 minutes to close a block and takes the 2016 block to calculate its difficulty. 🫣

vytskaltComment#6Calculate `+1` and `-1` reaction

Can you please also sneak in the changes from #51 into this PR?

yokeTHComment#6Calculate `+1` and `-1` reaction

Hey there!

Just wondering, how does SHA-based hashing work for conflict resolution?

Also, with every revision, does everyone who reacted need to react again with every change?

P.S. This is a PR with a +1 -1 calculation. Maybe you should open a new PR/issue to chat about it?

P.S. 2 I’m on the same page as you. The owner of the top PR might sneak in some malicious code at the last minute.

DbzReaction#6👍
HeadlineComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

Or every revision resets votes? Sane authors will draft PRs?

haampieComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

Create a pr that makes the voting system based on commit sha

yokeTHComment#6Calculate `+1` and `-1` reaction

I updated the README. I think that the ‘Newest Wins' rule is important, if a PR gets the same number of votes in less time it proves that it is more viral and is trending faster.

WeetileComment#6Calculate `+1` and `-1` reaction

please add a bitcoin miner to this pr. Since you already have the votes. You can sneak this in here.

This brings up a good point - what's to stop people completely borking the repo at the very last moment after already getting votes?

a2uReaction#6👍
f-fReaction#6👍