PR #168

12 votes · 12 up · 0 down

View on GitHub
12
Total Votes
+12
Upvotes
-0
Downvotes
+12-0

Comments(7)

bigintersmindComment#168Mergeability detection for automerge correction

Gah, I missed it in my last-minute testing; the package is ESM-only, so require() throws an error.

Added the one-line fix to #195.

matthewmayerComment#168Mergeability detection for automerge correction

My assumption is that if the daily action works, @skridlevsky will no longer do manual daily merges.

If the action fails he should manually do the merge following the RULES.

bigintersmindComment#168Mergeability detection for automerge correction

No worries! Once I reviewed your PR, I realized that I'd missed the rhyme detection update and forgot to update to daily merges! So it's great that you did it, because I may have merged an incomplete fix otherwise.

bpottleComment#168Mergeability detection for automerge correction

Aw, hell, did I basically just dupe this with #200?

openchaos-bot[bot]Comment#168Fix automerge to respect mergeability (RULES.md compliance)

🤖 OpenChaos Bot

Summary: This PR refactors the automerge workflow to only merge PRs with positive net votes (+1s minus -1s) and ensures that only mergeable PRs with passing CI checks are merged, adding checks for merge conflicts and CI status before merging. It prioritizes PRs with higher net votes and uses creation time as a tiebreaker.

Files changed: 1 (.github/workflows/automerge.yml)

Vibe: Sweet chaos surrender: let the robot overlords sort the wheat from the chafficionado.


openchaos-bot

All Activity(20)

bigintersmindComment#168Mergeability detection for automerge correction

Gah, I missed it in my last-minute testing; the package is ESM-only, so require() throws an error.

Added the one-line fix to #195.

matthewmayerComment#168Mergeability detection for automerge correction

My assumption is that if the daily action works, @skridlevsky will no longer do manual daily merges.

If the action fails he should manually do the merge following the RULES.

bigintersmindComment#168Mergeability detection for automerge correction

No worries! Once I reviewed your PR, I realized that I'd missed the rhyme detection update and forgot to update to daily merges! So it's great that you did it, because I may have merged an incomplete fix otherwise.

bpottleComment#168Mergeability detection for automerge correction

Aw, hell, did I basically just dupe this with #200?

openchaos-bot[bot]Comment#168Fix automerge to respect mergeability (RULES.md compliance)

🤖 OpenChaos Bot

Summary: This PR refactors the automerge workflow to only merge PRs with positive net votes (+1s minus -1s) and ensures that only mergeable PRs with passing CI checks are merged, adding checks for merge conflicts and CI status before merging. It prioritizes PRs with higher net votes and uses creation time as a tiebreaker.

Files changed: 1 (.github/workflows/automerge.yml)

Vibe: Sweet chaos surrender: let the robot overlords sort the wheat from the chafficionado.


openchaos-bot