PR #86

18 votes · 18 up · 0 down

View on GitHub
18
Total Votes
+18
Upvotes
-0
Downvotes
+18-0

Comments(3)

skridlevskyComment#86Fix pagination bug hiding older PRs

Maintenance Override: Immediate Merge

This PR fixes a critical infrastructure bug, not content.

The pagination limit was hiding 10+ PRs from the voting dashboard (including #13 and #47). Users couldn't vote on what they couldn't see. That's not chaos - that's broken.

Policy: Content PRs = Sunday votes only. Infrastructure fixes that restore fair voting = immediate merge.

skridlevskyComment#86Fix pagination bug hiding older PRs

Credit to @Kl0ven who spotted this issue first on Day 4.

openchaos-bot[bot]Comment#86Fix pagination bug hiding older PRs

🤖 OpenChaos Bot

Summary: The PR modifies the getOpenPRs function to paginate through the GitHub API to retrieve all open pull requests, as the API returns a limited number of PRs per request. It also adds better error handling for the GitHub API.

Files changed: 1 (src/lib/github.ts)

Impact: Medium - This affects the core functionality of fetching open PRs, which is essential for the app.


openchaos-bot

All Activity(22)

skridlevskyComment#86Fix pagination bug hiding older PRs

Maintenance Override: Immediate Merge

This PR fixes a critical infrastructure bug, not content.

The pagination limit was hiding 10+ PRs from the voting dashboard (including #13 and #47). Users couldn't vote on what they couldn't see. That's not chaos - that's broken.

Policy: Content PRs = Sunday votes only. Infrastructure fixes that restore fair voting = immediate merge.

skridlevskyComment#86Fix pagination bug hiding older PRs

Credit to @Kl0ven who spotted this issue first on Day 4.

openchaos-bot[bot]Comment#86Fix pagination bug hiding older PRs

🤖 OpenChaos Bot

Summary: The PR modifies the getOpenPRs function to paginate through the GitHub API to retrieve all open pull requests, as the API returns a limited number of PRs per request. It also adds better error handling for the GitHub API.

Files changed: 1 (src/lib/github.ts)

Impact: Medium - This affects the core functionality of fetching open PRs, which is essential for the app.


openchaos-bot

Fix pagination bug hiding older PRs

GitHub API defaults to 30 results per page. With 37+ open PRs, older ones like #13 were being hidden. This implements proper pagination to fetch all PRs.

Changes

  • Modified getOpenPRs() in src/lib/github.ts to loop through all pages
  • Uses per_page=100 and increments page number until no more results
  • Matches the pagination pattern already used in getPRVotes()