Closing this PR. The core bug (server-side Math.random() causing cached blank pages) was already fixed by PR #76, which moved the randomness check to IE6Layout.tsx (a client component). This PR is now only a minor code quality refinement of that fix and isn't worth a separate merge.
PR #173
34 votes · 33 up · 1 down
34
Total Votes
+33
Upvotes
-1
Downvotes
+33-1
Comments(7)
Equivalent code was included in the merged https://github.com/skridlevsky/openchaos/pull/76 freeDoom pull, so this will no longer be needed.
I considered adding this fix to #129, but it doesn't feel like it's in the spirit of the project. Even if it's a "good" trojan horse, it's still a trojan horse.
Lets see how many other PRs are being merged before this one is the top-most. I am torn between fixing things quickly and letting the rules play out to see when the fix comes naturally. I want to see the naturally emergent behaviour. By now, people have learned about this repo and should be able to find this and upvote it. OTOH, natural behaviour could also be "we are devs, we have fun, but we don't ignore a broken app in the sun".
Confirmed in local testing.
openchaos-bot[bot]Comment#173Fix: Move 1.337% randomness check client-side to prevent cached blank pages
🤖 OpenChaos Bot
Summary: This PR removes the random null return from the main page and adds it to the IE6Layout component, wrapped in a useEffect. Now the whole site might randomly disappear instead of just the homepage.
Files changed: 2 (src/app/page.tsx, src/components/IE6Layout.tsx)
Vibe: Escalation, but make it unpredictable.
All Activity(42)
Closing this PR. The core bug (server-side Math.random() causing cached blank pages) was already fixed by PR #76, which moved the randomness check to IE6Layout.tsx (a client component). This PR is now only a minor code quality refinement of that fix and isn't worth a separate merge.
Equivalent code was included in the merged https://github.com/skridlevsky/openchaos/pull/76 freeDoom pull, so this will no longer be needed.
I considered adding this fix to #129, but it doesn't feel like it's in the spirit of the project. Even if it's a "good" trojan horse, it's still a trojan horse.
Lets see how many other PRs are being merged before this one is the top-most. I am torn between fixing things quickly and letting the rules play out to see when the fix comes naturally. I want to see the naturally emergent behaviour. By now, people have learned about this repo and should be able to find this and upvote it. OTOH, natural behaviour could also be "we are devs, we have fun, but we don't ignore a broken app in the sun".
Confirmed in local testing.
openchaos-bot[bot]Comment#173Fix: Move 1.337% randomness check client-side to prevent cached blank pages
🤖 OpenChaos Bot
Summary: This PR removes the random null return from the main page and adds it to the IE6Layout component, wrapped in a useEffect. Now the whole site might randomly disappear instead of just the homepage.
Files changed: 2 (src/app/page.tsx, src/components/IE6Layout.tsx)
Vibe: Escalation, but make it unpredictable.