2
Total Votes
2
Upvotes
0
Downvotes
2
Unique PRs
+2-0

Activity

๐Ÿ’ฌ
DanielEScherzerReview comment#13

as noted below, PRs are now merged every day, so no need to track days remaining, remaining_until() will need updating too

๐Ÿ’ฌ
DanielEScherzerReview comment#13

per 54c4ca325394cf2e01e6f00e900ecad2ff01d49c merges are at 1900 UTC

    target.set_utc_hours(19);
๐Ÿ’ฌ
DanielEScherzerReview comment#13

needs update for #51 - probably just drop all of the day handling entirely

๐Ÿ’ฌ
DanielEScherzerReview comment#13

as noted below, PRs can have a net negative number of votes given downvotes

    votes: i32,
๐Ÿ’ฌ
DanielEScherzerReview comment#13

per #6 downvotes should be counted too:

        let upvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "+1")
            .count() as i32;
        let downvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "-1")
            .count() as i32;
        let votes = upvotes - downvotes;
โ–ธ
DanielEScherzerComment#141IE6BrowserChrome.tsx: open skridlevsky/openchaos GitHub repo

I would suggest that this is essentially an infrastructure fix and might be worth merging outside of the voting process, but obviously the decision is up to @skridlevsky

โ—

IE6BrowserChrome.tsx: open skridlevsky/openchaos GitHub repo

Rather than bpottle's fork. Follow up to #47