PR #13

1008 votes Β· 744 up Β· 264 down

View on GitHub
1008
Total Votes
+744
Upvotes
-264
Downvotes
+744-264

Comments(23)

πŸ’¬
DanielEScherzerReview comment#13

as noted below, PRs are now merged every day, so no need to track days remaining, remaining_until() will need updating too

πŸ’¬
DanielEScherzerReview comment#13

per 54c4ca325394cf2e01e6f00e900ecad2ff01d49c merges are at 1900 UTC

    target.set_utc_hours(19);
πŸ’¬
DanielEScherzerReview comment#13

needs update for #51 - probably just drop all of the day handling entirely

πŸ’¬
DanielEScherzerReview comment#13

as noted below, PRs can have a net negative number of votes given downvotes

    votes: i32,
πŸ’¬
DanielEScherzerReview comment#13

per #6 downvotes should be counted too:

        let upvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "+1")
            .count() as i32;
        let downvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "-1")
            .count() as i32;
        let votes = upvotes - downvotes;
β–Έ
lens0021Comment#13Rewrite it in rust

Regardless of your heated discussions, I wanted to share the news that GeoCities PR has been merged, and the site has truly transformed beautifully. https://www.openchaos.dev/ β†— ​It is beautiful not only on the outside but also on the inside, with a mix of Tailwind, inline styles, and raw CSS.

β–Έ
skridlevskyComment#13Rewrite it in rust

As per the rules, a PR must have no merge conflicts to be eligible for merge. #13 is being skipped until conflicts are resolved. Next eligible PR wins.

β–Έ
marcaddeoComment#13Rewrite it in rust

Sure, but 100% chaos would be a repository with the output of /dev/urandom, how useful is that?

I'd vote for that PR

β–Έ
embedding-shapesComment#13Rewrite it in rust

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

The chaos is the point?

Sure, but 100% chaos would be a repository with the output of /dev/urandom, how useful is that? Shouldn't it at least work and be relatively bug free, and let people change it?

The more code you add, the more likely it is to have bugs, and the harder it gets for people to change it. Shouldn't we aim to let it still be easy to contribute?

β–Έ
bpottleComment#13Rewrite it in rust

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

The chaos is the point?

β–Έ
embedding-shapesComment#13Rewrite it in rust

I pulled this branch down to see if I could "fix" it and was astonished it has as many upvotes as it does. They're all because of the title. There's no WASM, no Rust toolchain, zero Rust code at all as a matter of fact*. This is a branch that got halfway through a beer and remembered it had chores to do.

I think I'll start a new one.

*Ah, there's a binary and I do see the .rs I didn't before, dunno why it didn't scroll. Anyway, #91 works.

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

β–Έ
pvinisComment#13Rewrite it in rust

which part doesn't "go brr" enough for you?

all this extra complexity for just a meme..

β–Έ
bpottleComment#13Rewrite it in rust

I pulled this branch down to see if I could "fix" it and was astonished it has as many upvotes as it does. They're all because of the title. There's no WASM, no Rust toolchain, zero Rust code at all as a matter of fact*. This is a branch that got halfway through a beer and remembered it had chores to do.

I think I'll start a new one.

*Ah, there's a binary and I do see the .rs I didn't before, dunno why it didn't scroll. Anyway, #91 works.

β–Έ
julibuildsComment#13Rewrite it in rust

This is a serious question because I'm genuinely curious about using WASM with nextjs and vercel (or similar), does this PR improve performance while allowing everything else to be developed normally e.g. frontend React/JS, Nextjs middleware, etc.? Or does it also add more friction for future development?

β–Έ
mikerybkaComment#13Rewrite it in rust

I think this is bad because fewer people can read/write rust. It's going to make it harder for people to contribute for no real gain.

β–Έ
ksuryaComment#13Rewrite it in rust

I am here to negotiate bringing chaos each day first. Please!

β–Έ
MattMaginnissComment#13Rewrite it in rust

does this bring us up to feature parity with the most recent release?

β–Έ
lens0021Comment#13Rewrite it in rust

Perhaps the author wanted to say that rewriting everything in Rust is chaos and nonsense.

β–Έ
NSPC911Comment#13Rewrite it in rust

So in the end, actually WAY more than just 300 lines, thousands of lines added, for what? WASM? Again, why? More code, regardless of what language, regardless if hidden behind a dependency, makes it harder to change and more likely to break.

And why make a project that is all about "constantly changing" and "being easy to change" harder to change!? Makes no sense.

all for shits and giggles? someone would rewrite it in a different language, I don't know, this repository is for chaos itself

β–Έ
embedding-shapesComment#13Rewrite it in rust

tbh, 300 lines of that is the Cargo.lock file. But anyway, more screw ups = more chaos.

So in the end, actually WAY more than just 300 lines, thousands of lines added, for what? WASM? Again, why? More code, regardless of what language, regardless if hidden behind a dependency, makes it harder to change and more likely to break.

And why make a project that is all about "constantly changing" and "being easy to change" harder to change!? Makes no sense.

β–Έ
maximxlssComment#13Rewrite it in rust

less js => less bugs

All Activity(500)

πŸ’¬
DanielEScherzerReview comment#13

as noted below, PRs are now merged every day, so no need to track days remaining, remaining_until() will need updating too

πŸ’¬
DanielEScherzerReview comment#13

per 54c4ca325394cf2e01e6f00e900ecad2ff01d49c merges are at 1900 UTC

    target.set_utc_hours(19);
πŸ’¬
DanielEScherzerReview comment#13

needs update for #51 - probably just drop all of the day handling entirely

πŸ’¬
DanielEScherzerReview comment#13

as noted below, PRs can have a net negative number of votes given downvotes

    votes: i32,
πŸ’¬
DanielEScherzerReview comment#13

per #6 downvotes should be counted too:

        let upvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "+1")
            .count() as i32;
        let downvotes = reactions
            .iter()
            .filter(|reaction| reaction.content == "-1")
            .count() as i32;
        let votes = upvotes - downvotes;
⚑
hxc9Reaction#13πŸ‘
⚑
lsvReaction#13πŸ‘
β–Έ
lens0021Comment#13Rewrite it in rust

Regardless of your heated discussions, I wanted to share the news that GeoCities PR has been merged, and the site has truly transformed beautifully. https://www.openchaos.dev/ β†— ​It is beautiful not only on the outside but also on the inside, with a mix of Tailwind, inline styles, and raw CSS.

β–Έ
skridlevskyComment#13Rewrite it in rust

As per the rules, a PR must have no merge conflicts to be eligible for merge. #13 is being skipped until conflicts are resolved. Next eligible PR wins.

β–Έ
marcaddeoComment#13Rewrite it in rust

Sure, but 100% chaos would be a repository with the output of /dev/urandom, how useful is that?

I'd vote for that PR

⚑
iccoReaction#13πŸ‘Ž
⚑
bewReaction#13πŸ‘
⚑
kamnReaction#13πŸ‘Ž
β–Έ
embedding-shapesComment#13Rewrite it in rust

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

The chaos is the point?

Sure, but 100% chaos would be a repository with the output of /dev/urandom, how useful is that? Shouldn't it at least work and be relatively bug free, and let people change it?

The more code you add, the more likely it is to have bugs, and the harder it gets for people to change it. Shouldn't we aim to let it still be easy to contribute?

β–Έ
bpottleComment#13Rewrite it in rust

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

The chaos is the point?

β–Έ
embedding-shapesComment#13Rewrite it in rust

I pulled this branch down to see if I could "fix" it and was astonished it has as many upvotes as it does. They're all because of the title. There's no WASM, no Rust toolchain, zero Rust code at all as a matter of fact*. This is a branch that got halfway through a beer and remembered it had chores to do.

I think I'll start a new one.

*Ah, there's a binary and I do see the .rs I didn't before, dunno why it didn't scroll. Anyway, #91 works.

Again without any sort of justification for making the whole project a lot more complicated and potential to screw up. Why?!

β–Έ
pvinisComment#13Rewrite it in rust

which part doesn't "go brr" enough for you?

all this extra complexity for just a meme..

⚑
xirfReaction#13πŸ‘
β–Έ
bpottleComment#13Rewrite it in rust

I pulled this branch down to see if I could "fix" it and was astonished it has as many upvotes as it does. They're all because of the title. There's no WASM, no Rust toolchain, zero Rust code at all as a matter of fact*. This is a branch that got halfway through a beer and remembered it had chores to do.

I think I'll start a new one.

*Ah, there's a binary and I do see the .rs I didn't before, dunno why it didn't scroll. Anyway, #91 works.

β–Έ
julibuildsComment#13Rewrite it in rust

This is a serious question because I'm genuinely curious about using WASM with nextjs and vercel (or similar), does this PR improve performance while allowing everything else to be developed normally e.g. frontend React/JS, Nextjs middleware, etc.? Or does it also add more friction for future development?

β–Έ
mikerybkaComment#13Rewrite it in rust

I think this is bad because fewer people can read/write rust. It's going to make it harder for people to contribute for no real gain.

β–Έ
ksuryaComment#13Rewrite it in rust

I am here to negotiate bringing chaos each day first. Please!

β–Έ
MattMaginnissComment#13Rewrite it in rust

does this bring us up to feature parity with the most recent release?

⚑
ekgReaction#13πŸ‘
β–Έ
lens0021Comment#13Rewrite it in rust

Perhaps the author wanted to say that rewriting everything in Rust is chaos and nonsense.

β–Έ
NSPC911Comment#13Rewrite it in rust

So in the end, actually WAY more than just 300 lines, thousands of lines added, for what? WASM? Again, why? More code, regardless of what language, regardless if hidden behind a dependency, makes it harder to change and more likely to break.

And why make a project that is all about "constantly changing" and "being easy to change" harder to change!? Makes no sense.

all for shits and giggles? someone would rewrite it in a different language, I don't know, this repository is for chaos itself

β–Έ
embedding-shapesComment#13Rewrite it in rust

tbh, 300 lines of that is the Cargo.lock file. But anyway, more screw ups = more chaos.

So in the end, actually WAY more than just 300 lines, thousands of lines added, for what? WASM? Again, why? More code, regardless of what language, regardless if hidden behind a dependency, makes it harder to change and more likely to break.

And why make a project that is all about "constantly changing" and "being easy to change" harder to change!? Makes no sense.

⚑
jda5Reaction#13πŸ‘Ž
β–Έ
maximxlssComment#13Rewrite it in rust

less js => less bugs

⚑
mtsoReaction#13πŸ‘
PR #13 β€” Vote Breakdown | OpenChaos Feed