PR #119

60 votes · 59 up · 1 down

View on GitHub
60
Total Votes
+59
Upvotes
-1
Downvotes
+59-1
VoterVoteTime
lens0021+1
mario-donnarumma+1
FelixLttks+1
matthewmayer-1
mpetricek-corp+1
sevonj+1
JoppeDC+1
nobkd+1
md-weber+1
KaelWD+1
zero-ninetynine+1
Quik2007+1
sam-bessey+1
FabianMaknapp+1
ByteSculptor07+1
austinportal+1
GabrielleVivissi+1
bigintersmind+1
lucasotodegraeve+1
addshore+1
kronn+1
pbabbicola+1
Menerve+1
marcaddeo+1
ivanjermakov+1
WolleTD+1
a-daniel-pi+1
dfk1352+1
prostmich+1
NicolasBircksZR+1
herr-kneck+1
mheinric+1
bpottle+1
the-snesler+1
jamaa+1
devn1x+1
cat-125+1
Mad182+1
VisibleReality+1
Oeldin+1
ahornerr+1
exu-g+1
B-Nilson+1
olof-nord+1
KristianMarshall+1
BenceX100+1
d-mokliakov+1
wojciech-bigosinski+1
LNorman8+1
TheHamkerCat+1
simone-viozzi+1
TomasHubelbauer+1
Krafi2+1
Doomsel+1
npasslick+1
dem4gus+1
donomur+1
DanielEScherzer+1
pablo-rico-strivelabs+1
davencyw+1

All Activity(62)

◑
skridlevskyPR closed#119

Fix merge conflict indicator showing false positives

Problem

The health indicators merged in #8 are showing conflicts on PRs that don't have conflicts.

Root cause: getPRMergeStatus() and getCommitStatus() were missing auth headers. Without authentication, GitHub API returns null for mergeable, which defaults to false via ?? false.

Fix

Use getHeaders() instead of hardcoded headers - same pattern as all other API calls in this file.

Testing

Verified against GitHub API:

  • PR #13: mergeable: false (actual conflicts) ✅
  • PR #52: mergeable: true (no conflicts) ✅
  • PR #11: mergeable: true (no conflicts) ✅

cc @matthewmayer @FelixLttks