11
Total Votes
7
Upvotes
4
Downvotes
11
Unique PRs
+7-4

Activity

โšก
dem4gusReaction๐Ÿ‘
โ–ธ
dem4gusComment#149allow owner's PRs into the Hall of Chaos
image
โ—
dem4gusPR opened#149

allow owner's PRs into the Hall of Chaos

Fixes #148. The first pass at an implementation uses an explicitly defined list of PRs to be excluded from the Hall, which would need to be updated in the event of any future maintenance. I'm open to other options such as the addition of a [maint] tag to the title of any such future PRs, but there is still the problem of #86 to contend with.

As a side effect, this would allow maintenance PRs from anyone who notices a problem and fixes it, and not just @skridlevsky.

โ—ฏ
dem4gusIssue opened#148

Hall of Chaos does not display owner's PRs

#119 is not displayed on the Hall of Chaos.

Image

This is caused by business logic which filters out the repo owner's PRs.

  // Filter to only merged PRs (not just closed), exclude repo owner's maintenance PRs
  // Sort by merge time (newest first) since sort=updated may not reflect merge order
  const REPO_OWNER = owner;
  return prs
    .filter((pr) => pr.merged_at !== null && pr.user.login !== REPO_OWNER)
    .sort((a, b) => new Date(b.merged_at!).getTime() - new Date(a.merged_at!).getTime())
    .map((pr) => ({
      number: pr.number,
      title: pr.title,
      author: pr.user.login,
      url: pr.html_url,
      mergedAt: pr.merged_at!,
    }));

While the understandable intent is to exclude maintenance PRs, the result is that pull requests authored by @skridlevsky which go through the normal voting process are also excluded. The logic should be updated to address this oversight.

โšก
dem4gusReaction๐Ÿ‘
โ–ธ
dem4gusComment#130Change to text-only teletype style

I'm no CSS expert but would it be possible to add CRT-like filters such as scanlines and warping along the edges?

โšก
dem4gusReaction๐Ÿ˜„
โšก
dem4gusReaction๐Ÿ‘
โšก
dem4gusReaction๐Ÿ˜„